Rollup of 3 pull requests#156134
Conversation
found multiple instances where the equivalent of ExprParenthesesNeeded was done 'manually'. replaced them with a `ExprParenthesesNeeded::surrounding` call
Several printing functions (e.g. `short_string`) take a liftable parameter. This commit changes the call sites to do the lifting instead. This simplifies the type signatures and puts the `lift` calls inside `tls::with` calls which is where they usually appear, and the minor cost of having more `lift` call sites.
This doesn't match any of the other uses.
Co-authored-by: lcnr <rust@lcnr.de>
Regression test for trait-system-refactor#7 Adds a regression test for [`AliasRelate` hides info in transitive cases](rust-lang/trait-system-refactor-initiative#7). The example previously errored under the new solver but compiles cleanly now thanks to eager normalization (post-rust-lang/rust#119106). Verified on both the `old` and `next` revisions. The issue body has an older TODO suggesting a goal-proving variant test; per lcnr's recent note in `#t-types/trait-system-refactor` ("this isn't an issue as we eagerly normalize"), the underlying mechanism is now resolved across both inference and goal-proving paths, so this single regression test is sufficient. Closing the upstream issue manually after merge. r? @lcnr
…eeded, r=ShoyuVanilla refactor using ExprParenthesesNeeded where possible Found multiple instances where the equivalent of `ExprParenthesesNeeded` was done 'manually'. Replaced them with an `ExprParenthesesNeeded::surrounding` call.
…=oli-obk More lifting tweaks Details in individual commits. r? @oli-obk
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 783062d3c6 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 783062d (parent) -> 1d72d7e (this PR) Test differencesShow 26 test diffsStage 1
Stage 2
Additionally, 22 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1d72d7e8136faaebad3a85eeed432e6ea1b2ffab --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (1d72d7e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 1.5%, secondary -2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 495.891s -> 494.198s (-0.34%) |
Successful merges:
r? @ghost
Create a similar rollup